[patch, pr31490] Fix section type error.

Steve Ellcey sje@cup.hp.com
Wed Nov 17 20:37:00 GMT 2010


On Wed, 2010-11-17 at 10:40 -0800, Ian Lance Taylor wrote:

> The patch is still OK but I would still like the comment to be extended.
> Your extended comment says what the code does.  That is unnecessary--I
> can see what it does.  I would like the comment to say why it does that.
> 
> Thanks.
> 
> Ian

How about this:

          /* Here the reloc_rw_mask is not testing whether the section should
             be read-only or not, but whether the dynamic link will have to
             do something.  If so, we wish to segregate the data in order to
             minimize cache misses inside the dynamic linker.  If the data
             has a section attribute, ignore reloc_rw_mask() so that all data
             in a given named section is catagorized in the same way.  */

Steve Ellcey
sje@cup.hp.com



More information about the Gcc-patches mailing list