[patch libcpp]: PR/17349 - // comments cause weird behaviour with options -E -C
Kai Tietz
Kai.Tietz@onevision.com
Tue Nov 16 11:03:00 GMT 2010
gcc-patches-owner@gcc.gnu.org wrote on 15.11.2010 18:59:58:
> >>>>> "Kai" == Kai Tietz <ktietz70@googlemail.com> writes:
>
> Kai> this patch fixes the issue about -C and C++ comments as described
in
> Kai> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17349. This issue is
that
> Kai> within argument passing c++ comments need to be transformed into
> Kai> C-style comments, too.
>
> Thanks.
>
> Kai> + /* If we are currently in a directive or in agument parsing,
then
>
> Typo in "argument".
Thanks.
> Kai> + clen = ((pfile->state.in_directive || pfile->state.
> parsing_args) && type == '/') ? len + 2 : len;
>
> This line should be wrapped according to GNU coding standards.
Done.
> I think this patch should include a regression test.
Ok, added a testcase for gcc.dg/cpp
> Tom
>
ChangeLog libcpp
PR preprocessor/17349
* lex.c (save_comment): Handle in argument passing c++
comments special.
ChangeLog gcc/testsuite
PR preprocessor/17349
* gcc.dg/cpp/cmdlne-C3.c: New.
Ok for apply?
Regards,
i.A. Kai Tietz
| (\_/) This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr17349.diff
Type: application/octet-stream
Size: 2501 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20101116/4d6c8c60/attachment.obj>
More information about the Gcc-patches
mailing list