PATCH RFA: Build machinery: Autoconf support for Go

[Ian Lance Taylor]

Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:

> I cannot approve this (yet), but it looks OK except for a couple of
> nits: I'd wrap the contents in m4_version_prereq([2.69],, [...])
> so that they turn into a no-op once the code has been integrated into
> Autoconf (assuming for the moment that this will hapenn before 2.69),
> similarly to how we treat additions to config/override.m4.  You could
> also have added the code to that file, that would've avoided any further
> dependencies of generated aclocal.m4 and configure files (and in
> directories using AC_PROG_GO but not using automake the dependency on
> config/go.m4 will need to be tracked manually in Makefile.in).  OTOH
> the size of this warrants a new file for clarity.

Thanks for the review.  Fixed per below.

> I'm assuming that the macro definitions here are in sync with those
> posted on autoconf-patches.

They are intended to be, yes, though of course the autoconf patches have
not been accepted as of yet.

Is this version of the patch OK for mainline?

Ian


2010-11-11  Ian Lance Taylor  <iant@google.com>

	* go.m4: New file.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.patch
Type: text/x-diff
Size: 3294 bytes
Desc: go.m4
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20101111/add30cc2/attachment.bin>