Fix PR/46200 -- ivopt bug in test condition cost computation

Xinliang David Li davidxl@google.com
Wed Nov 3 23:10:00 GMT 2010


Submitted as r166280.

Thanks,

David

On Wed, Nov 3, 2010 at 3:27 AM, Zdenek Dvorak <rakdver@kam.mff.cuni.cz> wrote:
> Hi,
>
>> >> Hi, please review the patch attached. Regression and some performance
>> >> test is under going.
>> >
>> > it would be more consistent to either avoid using aff_combination functions
>> > in get_computation_cost_at completely, or rewrite it to use aff_combination
>> > instead of the current difference_cost/... functions (however, the latter
>> > would probably lead to somewhat slower compilation time).  The patch should
>> > also include a testcase for the problem.
>>
>> I agree -- the code for cost computation should match (or probably
>> share with) code in the rewrite functions -- however that is a much
>> larger task than is needed for this PR.
>>
>> I added a test case (marked with x86 target as ivopt are very target
>> sensitive). Regression test and minimal perf testing went ok.
>
> OK,
>
> Zdenek
>
>
>



More information about the Gcc-patches mailing list