[rs6000] Remove a couple of superfluous tests

Eric Botcazou ebotcazou@adacore.com
Sat May 29 08:47:00 GMT 2010


Hi,

there is a couple of superfluous tests in rs6000.c, namely:

  if (TARGET_AIX)
    RS6000_OUTPUT_BASENAME (file, fname);
  else
    assemble_name (file, fname);

RS6000_OUTPUT_BASENAME is either defined to assemble_name (darwin.h, sysv4.h) 
or to something else (xcoff.h), but xcoff.h is always included in conjunction 
with aix.h which defines TARGET_AIX to 1 so the test is a no-op.

OK for mainline?  [We detected the problem because the other uses of the macro 
aren't guarded so, if you happen to have a non-AIX XCOFF port, things break]


2010-05-29  Eric Botcazou  <ebotcazou@adacore.com>

	* config/rs6000/rs6000.c (rs6000_output_function_entry): Use
	RS6000_OUTPUT_BASENAME unconditionally.
	(rs6000_output_function_epilogue): Likewise.


-- 
Eric Botcazou
-------------- next part --------------
A non-text attachment was scrubbed...
Name: p.diff
Type: text/x-diff
Size: 956 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20100529/e2207eff/attachment.bin>


More information about the Gcc-patches mailing list