[testsuite] Skip gcc.c-torture/execute/960321-1.c on Solaris 2/x64 with Sun as

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Fri May 21 16:19:00 GMT 2010


Jason Merrill <jason@redhat.com> writes:

> On 05/04/2010 07:53 AM, Rainer Orth wrote:
>> The test passes when GNU as is used instead and is obviously a Sun as
>> bug (already reported).
>>
>> Since only 64-bit and non-gas is affected, I'd like to skip the test
>> only for !ilp32&&  !gas.  This needs a new effective-target keyword,
>> which this patch implements and documents.
>
> I'm not sure what the usual policy is for this sort of situation, but it
> seems odd to me to skip a test because of a vendor as bug; the test still
> fails, and it ought to work.  Maybe xfail it instead?

The problem with xfail is that it is an execute test: we still get the
... failed to produce an executable warning.  My goal is to reduce
testsuite noise in cases where we cannot do anything about the test
outcome and concentrate on real and new failures instead.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University



More information about the Gcc-patches mailing list