Request for code review - (ZEE patch : Redundant Zero extension elimination)

[Steven Bosscher]

On Mon, May 17, 2010 at 11:00 AM, Bernd Schmidt <bernds@codesourcery.com> wrote:
> On 05/12/2010 11:18 PM, Sriraman Tallam wrote:
>>> I know this most likely has been hashed before but why is this pass
>>> have SImode and DImode hardcoded?
>>> Can't you use the modes and then try a wider mode?  Or does that need
>>> a total rewrite of the pass?
>>
>> Yes, that requires modifying a large portion.
>
> I agree with Andrew.  Hardcoding the modes the way it's done in this
> pass really isn't up to the standards we should expect from new passes.
>  Please work on fixing this.

It is kind-of strange, though, that this comes up after two previous
reviews. It seems to me that it is not reasonable to hold up this
patch over this issue.

Ciao!
Steven