[PATCH] gc-improv merge (1/n): new libiberty interfaces
DJ Delorie
dj@redhat.com
Wed May 5 22:10:00 GMT 2010
As was noted, needs a space before the paren.
I like descriptive names ("I should have spelled creat with an 'e'")
but those do sound clumsy. Perhaps something with "typed" in the
name? splay_tree_new_typed ? splay_tree_new_typed_alloc ?
As for formal names in externs - no. Anything you put in a header
must be namespace-safe, so naming your parameters there means more
risk of conflicts.
You need to document the new functions.
You've changed a public API. Have you checked *every* project that
uses libiberty to see if anyone uses the old API?
More information about the Gcc-patches
mailing list