[patch, objc++, testsuite] PR35165, a few extra tidies.

[Mike Stump]

On Mar 27, 2010, at 8:52 AM, IainS wrote:
> As I said in my PR35165 Part 2 email, there are some opportunities to improve a little more for ObjC++.
> In addition to a couple of minor bug-fixes (posted separately), the following mop up testsuite-only changes.
> 
> tested on powerpc-apple-darwin9, i686-apple-darwin9 and ia32-pc-linux.

:-(  Testing on x86_64-apple-darwin10 I think results in part in:

Old tests that passed, that have disappeared: (Eeek!)

obj-c++.dg/encode-8.mm -fnext-runtime execution test

:-(

I suspect this is due to:

--- gcc/testsuite/obj-c++.dg/encode-8.mm	(revision 157742)
+++ gcc/testsuite/obj-c++.dg/encode-8.mm	(working copy)
@@ -2,7 +2,8 @@
    'BOOL *' (which should be encoded as '^c') and 'char *' (which
    should be encoded as '*').  */
 /* Contributed by Ziemowit Laski <zlaski@apple.com>.  */
-/* { dg-do run { xfail { "*-*-*" } } } PR27249 */
+/* { dg-xfail-run-if "PR27249" { *-*-* } { "-fgnu-runtime" } { "" } } */
+/* { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */

which I neglected to notice because it was buried way down deep in there.

Please don't remove testcases that are working and test valid things.

Index: gcc/testsuite/obj-c++.dg/cxx-ivars-2.mm
===================================================================
--- gcc/testsuite/obj-c++.dg/cxx-ivars-2.mm	(revision 157742)
+++ gcc/testsuite/obj-c++.dg/cxx-ivars-2.mm	(working copy)
@@ -1,7 +1,8 @@
 // Check if the '- .cxx_construct' and '-.cxx_destruct' methods get called
 // and if they perform their desired function.
 
-// { dg-do run { xfail { "*-*-*" } } } PR27247/PR23681
+// { dg-xfail-run-if "PR27247/PR23681" { *-*-* } { "-fgnu-runtime" } { "" } }
+// { dg-xfail-run-if "Needs OBJC2 ABI" { *-*-darwin* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } }
 // { dg-options "-fobjc-call-cxx-cdtors" }

suffers from the same issue.  I'm thinking the right solution is to:

Add:

/* { dg-do run { target *-*-darwin* } } */
/* { dg-skip-if "" { *-*-* } { "-fgnu-runtime" } { "" } } */

and then go from there.  Thoughts?