[PING] [PATCH] Debugging dump support for gengtype and some cleanups

[Laurynas Biveinis]

Ping?

http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01437.html

Thanks,
Laurynas

> This adds a new command line option -d for gengtype that makes it to
> dump (in an ad hoc format) its internal data structures to stdout. It
> is useful in finding out why some data types do not appear in gengtype
> output files, or why some do when they shouldn't. I have attached a
> compressed sample debugging output in gengtype-debug.zip
>
> Also this patch factors out duplicate code for finding out which
> output file to use for a given structure and has some other minor
> random cleanups.
>
> It has been tested on gc-improv branch for a few months.
>
> Bootstrapped/regtested on x86_64/linux together with other
> GC-to-obstack patches which I will submit next.
>
> OK for mainline?
>
> 2010-04-21  Laurynas Biveinis  <laurynas.biveinis@gmail.com>
>
>        * Makefile.in (build/gengtype.o): Add $(HASHTAB_H) to
>        dependencies.
>
>        * gengtype.h (erro_at_line): Constify pos argument.
>
>        * gengtype.c: Include hashtab.h.
>        (enum gc_used): Document GC_MAYBE_POINTED_TO.
>        (error_at_line): Constify pos argument.
>        (do_typedef): Initialize p->opt field.
>        (get_file_gtfilename): Fix comment typo.
>        (struct walk_type_data): Constify line field.
>        (get_output_file_for_structure): New function.
>        (write_local_func_for_structure): Constify orig_s argument.
>        Use get_output_file_for_structure.
>        (write_func_for_structure): Use get_output_file_for_structure.
>        (INDENT): New define.
>        (dump_pair, dump_type, dump_type_list, dump_typekind)
>        (dump_gc_used, dump_options, dump_fileloc, dump_type_u_s)
>        (dump_type_u_s_lang_struct, dump_type_u_a)
>        (dump_type_u_param_struct, dump_pair_list, dump_structures)
>        (dump_everything): New functions.
>        (seen_types): New variable.
>        (main): New variable do_dump.  Process "-d" command line option.
>        Call dump_everything if dump requested.

-- 
Laurynas