[build] Use *_sol2 GNU ld linker emulations on Solaris 2

Ralf Wildenhues Ralf.Wildenhues@gmx.de
Sat Mar 6 10:34:00 GMT 2010


* Rainer Orth wrote on Fri, Mar 05, 2010 at 10:13:19PM CET:
> Ralf Wildenhues writes:
> 
> > Please replace test -a and test -o in the patch with 'test && test'
> > and 'test || test'.  One reason -a and -o are not specified in POSIX is
> > that different systems implement operator precedence differently between
> > these two.  The shell || and && are evaluated strictly from left to
> > right (unlike the respective C operators), so you may need to add braces
> > for precedence of
> >> +       && test $in_tree_ld_is_elf = yes; then
> 
> Then this should be done wholesale.  The idiom I've used is a straight
> copy of similar constructs all over configure.ac.  Being different in a
> single place doesn't seem like a good idea to me.

Fair point.  Another cleanup for the todo list.

I still can't approve your patch of course.

Cheers,
Ralf



More information about the Gcc-patches mailing list