[PATCH C] Fix pr44517
Shujing Zhao
pearly.zhao@oracle.com
Tue Jun 22 09:57:00 GMT 2010
On 06/22/2010 03:40 PM, Manuel López-Ibáñez wrote:
> On 22 June 2010 09:05, Shujing Zhao <pearly.zhao@oracle.com> wrote:
>> Hi,
>>
>> This patch tries to improve diagnostic for wrong type name in function
>> declaration. It also changes the algorithm of function
>> c_parser_parms_list_declarator. If one of parameter declaration is wrong,
>> c_parser_parms_list_declarator would return NULL, not an empty parameter
>> information struct. A test case is added to test this change.
>>
>
> Great! One minor nit:
>
> - }
> + return false;
> }
>
> This should be return NULL.
>
> Don't need to send a new patch for this. Just wait for approval.
Oops, sorry. Gcc didn't detect it, is it because both 'false' and 'NULL' are 0?
is it a bug?
Thanks
Pearly
More information about the Gcc-patches
mailing list