PowerPC64 large toc model

Richard Guenther richard.guenther@gmail.com
Fri Jun 18 10:31:00 GMT 2010


On Tue, Jun 15, 2010 at 9:41 AM, Alan Modra <amodra@gmail.com> wrote:
> On Mon, Jun 14, 2010 at 02:48:42PM -0400, David Edelsohn wrote:
>> On Tue, Jun 8, 2010 at 8:57 AM, Alan Modra <amodra@gmail.com> wrote:
>> > PowerPC64 gcc support for a larger TOC via -mcmodel option.
>> The patch is okay, with the appropriate updates for the other recent patches.
>
> For reference, that was just making the first arg of
> legitimate_constant_pool_address_p a const_rtx, to suit the similar
> change to rs6000_mode_dependent_address.
>
>> But please change bigtoc_reg, bigtoc_high and bigtoc_low to something
>> else.  Maybe largetoc?
>
> Committed with those changes.

This broke bootstrap on linux64 with

11:55 < richi> ../../mem-ref2/gcc/config/rs6000/rs6000.c: In function
               'rs6000_override_options':
11:55 < richi> ../../mem-ref2/gcc/config/rs6000/rs6000.c:2775:3: error: suggest
               braces around empty body in an 'if' statement
               [-Werror=empty-body]

because in


          else                                                  \
            {                                                   \
              if (!rs6000_explicit_options.cmodel)              \
                SET_CMODEL (CMODEL_MEDIUM);                 \

SET_CMODEL expands to nothing.

Richard.



More information about the Gcc-patches mailing list