[patch] Set FPU defaults for -ffast-math on MIPS.

Kazu Hirata kazu@codesourcery.com
Fri Jun 11 21:42:00 GMT 2010


Hi Richard,

Thank you for a review.

> Could you give it a spin 64-bit GNU/Linux too?  I'd have expected...
>
>> 	* config/mips/linux.h (ENDFILE_SPEC): New.
>> 	* config/mips/linux64.h (ENDFILE_SPEC): New.
>
> ...this to trigger a redefinition error, since linux.h is included for
> 64-bit as well as 32-bit targets.  It would certainly be nice to only
> need the linux.h definition.

I've removed the changes to linux64.h.  As you point out, one definition 
is enough.

> It's probably a daft question, but why do both t-crtfms need a make rule
> for crtfastmath.o?

Actually we don't need the duplicate make rules, so I've removed t-crtfm 
for the next iteration.

However, we still need to add crtfastmath.o to EXTRA_PARTS in t-crtfm or 
to extra_parts in config.gcc because libgcc/Makefile.in checks to see if 
EXTRA_PARTS from libgcc and EXTRA_PARTS from gcc match.

Anyway, I'll post the next iteration shortly.

Thanks,

Kazu Hirata



More information about the Gcc-patches mailing list