pragma diagnostic push/pop

Tom Tromey tromey@redhat.com
Fri Jun 11 04:17:00 GMT 2010


>>>>> "DJ" == DJ Delorie <dj@redhat.com> writes:

DJ> This is long overdue...  first try on location-sensitive pragma-based
DJ> diagnostic control.

Nice!

DJ> @@ -703,30 +703,34 @@ handle_pragma_diagnostic(cpp_reader *ARG
[...]
DJ>    token = pragma_lex (&x);

DJ> @@ -313,16 +313,72 @@ diagnostic_classify_diagnostic (diagnost
[...]
DJ> +  /* Handle pragmas separately, since we need to keep track of *where*
DJ> +     the pragmas were.  */
DJ> +  if (input_location > 0)

I would prefer it if new code avoided the global input_location and
instead took a source_location as a parameter.

This ought to be pretty easy since handle_pragma_diagnostic has a token
available.

Tom



More information about the Gcc-patches mailing list