[PATCH] Speed up find_loc_in_1pdv (PR debug/41371)
Jakub Jelinek
jakub@redhat.com
Thu Jun 10 20:01:00 GMT 2010
On Thu, Jun 10, 2010 at 02:07:38PM -0300, Alexandre Oliva wrote:
> On Jun 10, 2010, Richard Guenther <rguenther@suse.de> wrote:
>
> > There's some odd spacing here:
>
> > + dv = dv_from_value (node->loc);
> > + rvar = (variable) htab_find_with_hash (vars, dv,
> > dv_htab_hash (dv));
>
> Thanks, fixed.
>
> > Ok for trunk and the branch.
>
> Here's the patch I installed, with an additional comment.
>
> > Do you have updated timings for the testcases in the PR?
>
> No, I haven't measured the timing difference.
I've tried to measure the difference on --enable-checking=release
cc1/cc1plus, though the results vary a lot, but in general, except for one
of the runs, the new cc1/cc1plus was faster:
time ./cc1plus.160558 -quiet -O2 -g bug90.cc -o bug90.s1; time ./cc1plus.160559 -quiet -O2 -g bug90.cc -o bug90.s2
user 2m54.723s
user 2m41.328s
time ./cc1plus.160558 -quiet -O2 -g bug90.cc -o bug90.s1; time ./cc1plus.160559 -quiet -O2 -g bug90.cc -o bug90.s2
user 3m18.700s
user 2m30.857s
time ./cc1plus.160558 -quiet -O2 -g bug90.cc -o bug90.s1; time ./cc1plus.160559 -quiet -O2 -g bug90.cc -o bug90.s2
user 3m12.270s
user 2m39.853s
time ./cc1plus.160558 -quiet -m32 -quiet -g -Os -fomit-frame-pointer bug-611650_analysis.ii; time ./cc1plus.160559 -quiet -m32 -quiet -g -Os -fomit-frame-pointer bug-611650_analysis.ii
user 2m8.505s
user 1m58.971s
time ./cc1plus.160558 -quiet -m32 -quiet -g -Os -fomit-frame-pointer bug-611650_analysis.ii; time ./cc1plus.160559 -quiet -m32 -quiet -g -Os -fomit-frame-pointer bug-611650_analysis.ii
user 2m39.698s
user 2m5.826s
time ./cc1plus.160558 -quiet -m32 -quiet -g -Os -fomit-frame-pointer bug-611650_analysis.ii; time ./cc1plus.160559 -quiet -m32 -quiet -g -Os -fomit-frame-pointer bug-611650_analysis.ii
user 2m57.066s
user 1m55.971s
time ./cc1.160558 -m32 -fPIC -fno-strict-aliasing -g -O2 rh598310.i -quiet; time ./cc1.160559 -m32 -fPIC -fno-strict-aliasing -g -O2 rh598310.i -quiet
user 0m56.140s
user 0m53.239s
time ./cc1.160558 -m32 -fPIC -fno-strict-aliasing -g -O2 rh598310.i -quiet; time ./cc1.160559 -m32 -fPIC -fno-strict-aliasing -g -O2 rh598310.i -quiet
user 1m4.315s
user 1m9.517s
time ./cc1.160558 -m32 -fPIC -fno-strict-aliasing -g -O2 rh598310.i -quiet; time ./cc1.160559 -m32 -fPIC -fno-strict-aliasing -g -O2 rh598310.i -quiet
user 0m56.003s
user 0m54.495s
Jakub
More information about the Gcc-patches
mailing list