[Patch, RQ Review] convert emulated TLS so that it works with LTO and WHOPR.

IainS developer@sandoe-acoustics.co.uk
Thu Jun 10 10:26:00 GMT 2010


Hi Dave,

other comments absorbed pending an update if the solution is deemed  
acceptable.

On 10 Jun 2010, at 01:49, Dave Korn wrote:

>> +  TREE_USED (to) = TREE_USED (decl);
>> +
>>   TREE_STATIC (to) = TREE_STATIC (decl);
>> -  TREE_USED (to) = TREE_USED (decl);
>> -  TREE_PUBLIC (to) = TREE_PUBLIC (decl);
>>   DECL_EXTERNAL (to) = DECL_EXTERNAL (decl);
>>   DECL_COMMON (to) = DECL_COMMON (decl);
>> +
>> +  TREE_PUBLIC (to) = TREE_PUBLIC (decl);
>
>  Should avoid non-functional shuffling of existing code.

Well, I'm happy to go with the status quo.
However, I have a point of view that collecting together items that  
are related (even though it makes no functional change to the code's  
behavior) does make a benefit in longer term maintenance.

Thanks for reviewing,
Iain



More information about the Gcc-patches mailing list