[PATCH,c++] convert cp_parser.unparsed_function_queues &co. to VECs

Mark Mitchell mark@codesourcery.com
Tue Jun 8 15:31:00 GMT 2010


Nathan Froyd wrote:

> 	* parser.c (cp_default_arg_entry): Declare.  Declare a VEC of it.

OK in principle; one question below:

> -      for (TREE_PURPOSE (parser->unparsed_functions_queues)
> -	     = nreverse (TREE_PURPOSE (parser->unparsed_functions_queues));
> -	   (queue_entry = TREE_PURPOSE (parser->unparsed_functions_queues));
> -	   TREE_PURPOSE (parser->unparsed_functions_queues)
> -	     = TREE_CHAIN (TREE_PURPOSE (parser->unparsed_functions_queues)))
> +      for (ix = 0;
> +	   VEC_iterate (cp_default_arg_entry, unparsed_funs_with_default_args,
> +			ix, e);
> +	   ix++)

Does this still iterate through things in the same order?  That's
important, IIRC.  I couldn't quite follow the changes to build up and
iterate through these lists, but would you please double-check?  If you
do need to reverse the iteration, that's an obvious change; just post
the final patch after check-in.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713



More information about the Gcc-patches mailing list