[Patch, toplevel/config] fix tls.m4 configure race condition (bootstrap/PR43170)

[IainS]

Hi Ralf,

On 6 Jun 2010, at 14:47, Ralf Wildenhues wrote:

> Hi Iain,
>
> * IainS wrote on Sun, Jun 06, 2010 at 02:58:40PM CEST:
>> The bug exists on 4.4, 4.5 and trunk..
>> ...  so OK for all?
>
> You haven't mentioned how you tested the patch; bootstrap and  
> regtest on
> what system?

It's been bootstrapped on *-apple-darwin{9,10} for a few days now  
(sorry, that is mentioned in the PR thread, but I realize I should  
have said here too).
I've had no feedback so far from any other emutls target (there seem  
to be quite a few, in fact), but I'd say that the fault is verging on  
obvious, once identified.

> When you get approval for trunk, you need to sync this change to src
> or ask somebody to do that for you.  Hmm, maybe patch authors should
> acknowledge this bit too when asking for approval.

Hm. OK, you got me there ;-)
.. just goes to show I've still a lot to learn.

Perhaps, in this case, it would be better for someone else to apply  
the patch?
(I haven't looked at the implications for other dependents of src, and  
don't claim to know my way around the other trees).

> FWIW, the patch looks good to me, but I cannot approve it.

thanks for the review and pointing out about src,
Iain

>
> Cheers,
> Ralf
>
>> config/ChangeLog:
>> 	
>> 	PR bootstrap/43170
>> 	* tls.m4 (GCC_CHECK_TLS): Adjust test variables scope and position.
>>
>> libgomp/ChangeLog:
>> 	
>> 	PR bootstrap/43170
>> 	* configure: Regenerated.
> [...]