An unreviewed ARM patch
Richard Earnshaw
rearnsha@arm.com
Fri Jun 4 15:53:00 GMT 2010
On Fri, 2010-06-04 at 06:16 -0700, Kazu Hirata wrote:
> Hi,
>
> Could someone please review the following patch?
>
> [patch] arm: Improve arm_rtx_costs_1 for Thumb2.
> http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00958.html
>
Hmm, I agree that there's probably some code in the rest of the MINUS
case that should be shared. I'm not convinced, however, that we should
fall through into the PLUS case: most of the code from that point on
will only apply if we have RSB (and we don't in Thumb-2).
So maybe the check should be moved to the end of the MINUS code (ie just
before the fall-through) and then simplified to remove the sub-cases
that have already been handled.
R.
More information about the Gcc-patches
mailing list