[Patch, Fortran] PR 44929: Parsing error of derived type name starting with 'REAL'
Steve Kargl
sgk@troutmask.apl.washington.edu
Fri Jul 30 17:11:00 GMT 2010
On Fri, Jul 30, 2010 at 06:37:19PM +0200, Janus Weil wrote:
> >> My patch improves Steve's earlier patch in two details:
> >
> > You may also cite him in the ChangeLog. Even if the patch is close to
> > obvious, there is indeed some of Steve's work in it. ;-)
>
> Sure.
There's no problem with omitting my name. The important
thing is to squash the bug.
> >> I think the regressions reported in PR 45005 after Steve's commit were
> >> an unrelated OOP issue, which has probably been fixed by Mikael's
> >> recent patch for PR 42051/44064 (thanks for that).
> >
> > Please check that they are not exposed by -fno-whole-file before committing.
>
> Yes, seems to work also with -fno-whole-file.
>
>
> >> The patch has been regtested on x86_64-unknown-linux-gnu. Ok for
> >> trunk? (And 4.5?)
> >
> > OK, thanks
>
> Thanks for the review. Will commit shortly.
>
Is it possible to merge the 2nd diff I attached to
the PR, which handles the intrinsics type in a better
way? If not, I'll look into a clean up patch at
some point in the future.
--
Steve
More information about the Gcc-patches
mailing list