ifcvt/crossjump patch: Fix PR 42496, 21803

Eric Botcazou ebotcazou@adacore.com
Tue Jul 27 22:38:00 GMT 2010


> BTW, this is essentially the same thing that's done in the main loop in
> ifcvt.c (do you also see it as a kludge there?), where I originally
> implemented this optimization, and you were the one who suggested I move
> it to cfgcleanup.c.  Maybe you misunderstood the optimization back then
> and thought it was just CFG manipulation?  That's simply not the case;
> the analogy with crossjumping doesn't entirely hold.

Yes, I still think that it will be more useful in cfgcleanup.c.  And it's 
another form of code commonization so I still think that implementing it using 
CFG manipulations is the best approach.

> Please explain what you are thinking.  If you have a clever way to do
> it, show it.  If you have just not thought it through sufficiently,
> please do not continue to hold up a useful improvement.

Fair enough.  Since I don't have enough time at the moment to experiment 
myself, I guess I have to withdraw my objections.

Please run this by another maintainer though.

-- 
Eric Botcazou



More information about the Gcc-patches mailing list