[Patch, Fortran] More clean-up with try-finally

Tobias Burnus burnus@net-b.de
Tue Jul 20 21:22:00 GMT 2010


Daniel Kraft wrote:
> I've marked two points in the patch with an XXX comment:  First, I
> created a new global variable in trans-decl that keeps track of the
> currently trans'ed procedure's gfc_symbol (instead of its return
> label).  I did not find any existing feature to get it, although I may
> well image there is one.  Did I miss it?

I think there is not yet such a variable.

> Second, in gfc_trans_return, se.post is added to the code after the
> exit jump -- maybe I did completely misunderstand something, but to me
> this makes no sense (as it will not be executed anyway); I guess that
> this just never really mattered.  But I may be wrong -- so can this
> line go?  And if so, why can we be sure that se.post needs never be
> handled? And if I'm wrong, why?

I think this line can go.

> Ok for trunk once I can bootstrap again and there are no regressions?

OK. Thanks for the patch!

Tobias



More information about the Gcc-patches mailing list