[patch, fortran] PR37077 Implement Internal Unit I/O for character KIND=4, Part 1
Tobias Burnus
burnus@net-b.de
Mon Jul 12 21:44:00 GMT 2010
Jerry DeLisle wrote:
> On 07/12/2010 05:27 AM, Tobias Burnus wrote:
>> Typo: s/internel/internal/
>>
>> + if (dtp->common.unit) /* char4 internel unit. */
>>
> OK
>
>> Question: Why is this unlikely? I understand that wide-char I/O is
>> unlikely, but for write_default_char4 writing to a wide-char internal
>> unit does not seem to be much more unlikely than writing to a file unit.
>> (Ditto a few lines later; on the other hand, using unlikely in "write_a"
>> is fine.)
>>
> OK
>
>> Finally, I miss tests for the test suit.
> First of several test cases attached.
The patch is OK. Thanks!
Tobias
More information about the Gcc-patches
mailing list