[patch i386]: Add support of "hotfix" -feature for x64

[Richard Guenther]

On Wed, Jul 7, 2010 at 10:27 AM, Kai Tietz <Kai.Tietz@onevision.com> wrote:
> Hello,
>
> Jakub Jelinek <jakub@redhat.com> wrote on 07.07.2010 09:25:20:
>
>> On Wed, Jul 07, 2010 at 09:15:45AM +0200, Kai Tietz wrote:
>> > this is the more improved patch, which handles for Wine linux the
>> > hotfix part via ASM_DECLARE_FUNCTION_NAME, too.
>
> I renamed by this patch the SUBTARGET_ASM_DECLARE_FUNCTION_NAME to
> ASM_DECLARE_OS_FUNCTION_NAME as suggested.
>
>> This is very ugly.  An OS isn't a subtarget of any kind.
>> If this is really the way to go, use ASM_DECLARE_OS_FUNCTION_NAME
>> or something similar.
>>
>> BTW,
>>
>>   bool is_ms_hook = ((decl && ix86_function_ms_hook_prologue (decl)) ?
> true
>>                                                                     :
> false);
>>
>> is horribly ugly.  You should just use
>
> Cleaned up.

I don't see the "cleaned up" part.

Can you please revert the original patch that caused the massive
breakage on *-linux and post a fixed patch instead (the patch below
doesn't make sense to me on its own).

Thanks,
Richard.

> ChangeLog
> 2010-07-07  Kai Tietz
>
>        PR target/44850
>        * config/i386/i386.c (ix86_asm_declare_function_name): Add
>        xname local variable to allow its override as used in darwin.
>        * config/i386/i386.h (SUBTARGET_ASM_DECLARE_FUNCTION_NAME):
>        Rename in comment to ASM_DECLARE_OS_FUNCTION_NAME.
>        * config/darwin.h (ASM_DECLARE_OS_FUNCTION_NAME): New macro.
>        (ASM_DECLARE_FUNCTION_NAME): Use ASM_DECLARE_OS_FUNCTION_NAME.
>        * config/elfos.h: Likewise.
>        * config/netbsd-aout.h: Likewise.
>        * config/openbsd.h: Likewise.
>        * config/i386/cygming.h (SUBTARGET_ASM_DECLARE_FUNCTION_NAME):
>        Rename to ASM_DECLARE_OS_FUNCTION_NAME.
>
>
> Ok for apply?
>
> Regards,
> Kai
>
> |  (\_/)  This is Bunny. Copy and paste Bunny
> | (='.'=) into your signature to help him gain
> | (")_(") world domination.
>
>