[PR debug/42896] introduce value uids to stabilize value compares

Richard Guenther richard.guenther@gmail.com
Sun Jan 31 05:54:00 GMT 2010


On Sun, Jan 31, 2010 at 12:35 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
> On Jan 30, 2010, Richard Guenther <richard.guenther@gmail.com> wrote:
>
>> Any reason to make uid signed (I suppose because decl uids are signed)?
>
> Yup.
>
>> I suppose you initialize the cselib
>> uid with next_decl_uid to avoid clashes between them?
>
> Yup.
>
>> Is that necessary for this particular patch
>
> Nope.  The only difference is the arbitrary initial value.  It has to be
> chosen (and reset) one way or another, so we might as well set it in a
> way that enables the bitmaps IIRC you suggested.
>
>> If so please remove that bits from this patch.
>
> I'd rather not waste time retesting another version of this patch just
> to change an arbitrary value.  What would we gain from such a change?

The change is not to export next_decl_uid from tree.c via that function.

Richard.



More information about the Gcc-patches mailing list