[ping] Re: [patch] fix ldd version check

[Matthias Klose]

On 18.01.2010 02:20, Matthias Klose wrote:
> On 18.01.2010 00:16, Joseph S. Myers wrote:
>> On Sun, 17 Jan 2010, Matthias Klose wrote:
>>
>>> There are two glitches in the ldd version check. Only the first line
>>> (starting
>>> with ldd) should be used to extract the version number, else the
>>> copyright
>>> year is extracted as glibc minor version number. ldd built from the
>>> eglibc
>>> project identifies itself as 'ldd (EGLIBC) 2.10.2' (at least how
>>> available/patched in Debian). Unsure if the changed version check is
>>> now too
>>> sloppy. Ok for the trunk?
>
>> The GNU Coding Standards say that the version number is the part after
>> the
>> last space in the first line.
>
> updated. noticed that you don't have to use character classes. CCed
> Jason as submitter of the original patch.
>
> Matthias
>

ping, is Jason's approval sufficient, or do I need approval from a build maintainer?

   Matthias