Summary: unreviewed hook doc patches

Joseph S. Myers joseph@codesourcery.com
Tue Jan 26 11:45:00 GMT 2010


On Tue, 19 Jan 2010, Joern Rennecke wrote:

> TARGET_HANDLE_C_OPTION
> http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00711.html

OK.

> TARGET_EH_RETURN_FILTER_MODE
> http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00713.html

More explanation or cross-reference is needed for what "filter value" 
means.

> TARGET_UNWIND_WORD_MODE
> http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00768.html

Should state what the default uses.

> TARGET_OPTION_PRAGMA_PARSE
> http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00821.html

This says what happens if args is NULL, but says nothing about the meaning 
of a non-NULL value (presumably it's not simply a boolean, or it would be 
bool rather than tree).  Nor is anything said about *how* pop_target 
"specifies the default options to use" (even a reference to code that 
defines how options correspond to trees, for example).

> TARGET_RESOLVE_OVERLOADED_BUILTIN
> http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00831.html

OK if you change "really has type VEC(tree,gc)* ." to "really has type 
@samp{VEC(tree,gc)*}.".

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Gcc-patches mailing list