RFA: Fix TARGET_OPTION_VALID_ATTRIBUTE_P in ChangeLog-2008 (Was: Re: RFA: hook doc patch (85/112): TARGET_OPTION_VALID_ATTRIBUTE_P)
Joern Rennecke
amylaar@spamcop.net
Sun Jan 17 05:03:00 GMT 2010
Quoting Gerald Pfeifer <gerald@pfeifer.com>:
> On Sat, 16 Jan 2010, Joern Rennecke wrote:
>> * tm.texi (TARGET_OPTION_VALID_ATTRIBUTE_P): Fix name.
>
> Yes, but please also mention the other name so that someone doing a
> search has a chance of making the connection. Okay with that change.
This is the text I have now in the patch I have scheduled to be applied:
* tm.texi (TARGET_OPTION_VALID_ATTRIBUTE_P): Fix name, it was
misspelled as TARGET_VALID_OPTION_ATTRIBUTE_P.
> (I believe there was another, similar case and it would be great could
> you make the same change to the ChangeLog there.)
What happened was that the hook was called TARGET_OPTION_VALID_ATTRIBUTE_P
right from the start, but the ChangeLog and documentation had it as
TARGET_VALID_OPTION_ATTRIBUTE_P .
Usually fixes to ChangeLog don't require approval, but this case is unusual
in that it's so long after the original check-in the entry is already in
ChangeLog-2008, it is not obvious what the best text to describe the
doc/tm.texi change from back than is, and it was not my patch to begin with.
I have attached a patch to change ChangeLog-2008.
-------------- next part --------------
Index: ChangeLog-2008
===================================================================
--- ChangeLog-2008 (revision 155367)
+++ ChangeLog-2008 (working copy)
@@ -13159,7 +13159,7 @@
(-fsched-stalled-insns): Ditto.
(-fsched-stalled-insns-dep): Ditto.
- * target-def.h (TARGET_VALID_OPTION_ATTRIBUTE_P): Add default
+ * target-def.h (TARGET_OPTION_VALID_ATTRIBUTE_P): Add default
definition.
(TARGET_OPTION_SAVE): Ditto.
(TARGET_OPTION_RESTORE): Ditto.
@@ -13218,7 +13218,8 @@
* doc/c-tree.texi (DECL_FUNCTION_SPECIFIC_TARGET): Document new macro.
(DECL_FUNCTION_SPECIFIC_OPTIMIZATION): Ditto.
- * doc/tm.texi (TARGET_VALID_OPTION_ATTRIBUTE_P): Document new hook.
+ * doc/tm.texi (TARGET_VALID_OPTION_ATTRIBUTE_P): [sic] Add
+ Documentation pertaining to new hook TARGET_OPTION_VALID_ATTRIBUTE_P.
(TARGET_OPTION_SAVE): Ditto.
(TARGET_OPTION_RESTORE): Ditto.
(TARGET_OPTION_PRINT): Ditto.
@@ -13397,7 +13398,7 @@
ix86_init_mmx_sse_builtins.
(ix86_expand_builtin): If the current ISA doesn't support a given
builtin, signal an error.
- (TARGET_VALID_OPTION_ATTRIBUTE_P): Set target hook.
+ (TARGET_OPTION_VALID_ATTRIBUTE_P): Set target hook.
(TARGET_SET_CURRENT_FUNCTION): Ditto.
(TARGET_OPTION_SAVE): Ditto.
(TARGET_OPTION_RESTORE): Ditto.
More information about the Gcc-patches
mailing list