RFA: hook doc patch (49/112): TARGET_SCHED_DFA_NEW_CYCLE

Gerald Pfeifer gerald@pfeifer.com
Sat Jan 16 23:00:00 GMT 2010


On Fri, 15 Jan 2010, Joern Rennecke wrote:
>	* tm.texi (TARGET_SCHED_DFA_NEW_CYCLE): Add argument names.

Index: tm.texi
===================================================================
--- tm.texi	(revision 155367)
+++ tm.texi	(working copy)
@@ -6542,8 +6592,7 @@ schedules to choose the best one.
 The default is that any ready insns can be chosen to be issued.
 @end deftypefn
 
-@deftypefn {Target Hook} int TARGET_SCHED_DFA_NEW_CYCLE (FILE *, int, rtx, int, int, int *)
-
+@deftypefn {Target Hook} int TARGET_SCHED_DFA_NEW_CYCLE (FILE *@var{dump_file}, int @var{verbose}, rtx @var{insn}, int @var{last_sched_cycle}, int @var{cur_cycle}, int *@var{sort_p})

In the actual code (config/ia64/ia64.c) the first parameter is called
dump, and this is also more consistent with some other cases, so let's
go for that.

(It's a bit of a mess admittedly, with the reorder2 hooks usually calling 
this variable file.)

The third and fourth parameters are called last_clock and clock, there,
and somewhat similarily in config/sh/sh.c, the only other instance.

Can you follow the naming in config/ia64?  The patch is fine with these
changes.

Gerald

PS: Bonus points if you sync config/sh as well...



More information about the Gcc-patches mailing list