Ping Ping: [PATCH] RFA: Add a small indication to warnings that are promoted to errors

[Richard Guenther]

On Mon, Jan 4, 2010 at 1:55 PM, Simon Baldwin <simonb@google.com> wrote:
> Second ping.
>
>
> 2009/12/8 Simon Baldwin <simonb@google.com>
>>
>> http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01101.html
>> http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01197.html
>>
>> Anyone care to give this patch the thumbs up or down?  I'll take a decision on either of the two variants of this.
>>
>> The first variant appends "[was warning]" to the end of the diagnostic.  Visually somewhat unappealing, but unlikely to cause problems for scripts that parse gcc diagnostics.
>>
>> The second variant changes the diagnostic's intro from "error:" to "error: warning:".  Visually more consistent, but potentially a problem for scripts that parse gcc output.

I still definitely favor the error: warning: variant (knowing nothing
about possible
impact on tools parsing gcc output).  I'll leave approval to diagnostics
maintainers though.

Thanks,
Richard.