[PATCH] Fix PR42531: lto generates invalid assembler ".section" directives.
Richard Guenther
richard.guenther@gmail.com
Fri Jan 1 12:10:00 GMT 2010
On Thu, Dec 31, 2009 at 7:05 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Dec 31, 2009 at 10:17 AM, Dave Korn
> <dave.korn.cygwin@googlemail.com> wrote:
>> Dave Korn wrote:
>>
>>> Rather than continue tracking them down one by one, I will try modifying
>>> lto_get_section_name() itself to skip a leading asterisk, which might have
>>> been the better approach to try in the first place. I'll bootstrap it on a
>>> linux system and see if it solves these new FAILs.
>>
>> H.J. Lu wrote:
>>
>>> We have a mismatch among all callers of lto_get_section_name. We
>>> should fix it in lto_get_section_name, not its callers. OK for trunk?
>>
>> You beat me to it while I was still updating all the prerequisites on my old
>> linux vm! This matches what I was thinking of.
>>
>> You might perhaps want to guard against null before testing name[0], because
>> as the function currently stands, it would behave sensibly if name was passed
>> in as NULL; the NULL would just act as an early terminator in the varargs
>> passed to concat(), and you'd get back the plain LTO_SECTION_NAME_PREFIX
>> unadorned. But then again you might just want to assert, because this should
>> really almost certainly never happen.
>>
>
> Here is the updated patch. OK for trunk?
Ok.
Thanks,
Richard.
>
> --
> H.J.
>
More information about the Gcc-patches
mailing list