PING: [PATCH gcc/ebitmap] fix for ebitmap_clear_bit()

Nicolas BENOIT nbenoit@tuxfamily.org
Thu Feb 25 18:21:00 GMT 2010


On 02/24/2010 09:26 PM, Diego Novillo wrote:
> On Wed, Feb 24, 2010 at 13:32, Nicolas BENOIT<nbenoit@tuxfamily.org>  wrote:
>> Hi all,
>>
>> A while ago, I submitted a few patches for ebitmap.
>>
>> Two of them have been validated and are still waiting for commit.
>>
>> http://gcc.gnu.org/ml/gcc-patches/2009-09/msg01921.html
>> http://gcc.gnu.org/ml/gcc-patches/2009-09/msg01547.html
>
> I will commit them for you.  RMs, is this OK at this stage?  The
> patches were approved long ago, but fell through the cracks for the
> final commit.
>
>
> Thanks.  Diego.
>

Patch http://gcc.gnu.org/ml/gcc-patches/2009-09/msg01547.html
is not applying to trunk since the big whitespace removal, here is an 
updated version :


Index: ebitmap.c
===================================================================
--- ebitmap.c	(revision 157065)
+++ ebitmap.c	(working copy)
@@ -254,8 +254,13 @@
        if (!have_eltwordindex)
  	eltwordindex = sbitmap_popcount (map->wordmask, wordindex);

-      if (map->cache != NULL && map->cacheindex == eltwordindex)
-	map->cache = NULL;
+      if (map->cache != NULL)
+        {
+          if (map->cacheindex == wordindex)
+            map->cache = NULL;
+          else if (map->cacheindex > wordindex)
+            map->cache = map->cache - 1;
+        }

        RESET_BIT (map->wordmask, wordindex);



More information about the Gcc-patches mailing list