[PATCH] MicroBlaze support - 2 of 6 - backend
Michael Eager
eager@eagercon.com
Fri Feb 19 20:35:00 GMT 2010
Joseph S. Myers wrote:
> On Thu, 4 Feb 2010, Michael Eager wrote:
>
>> New files under config/microblaze can be found at
>> http://gcc.gnu.org/viewcvs/branches/microblaze/gcc/config/microblaze/
>
>> +#ifndef __MICROBLAZE_PROTOS__
>> +#define __MICROBLAZE_PROTOS__
>
> Using names in the implementation namespace in host header files is a bad
> idea; use GCC_MICROBLAZE_PROTOS_H instead.
>
>> Index: microblaze/microblaze.c
> [...]
>> +#include "c-pragma.h"
>
> C-family headers should not be included in $target.c files. If you are
> defining hooks for the C-family front ends, do so in separate $target-c.c
> files to avoid breaking building non-C-family front ends; otherwise, you
> shouldn't need such an include.
>
>> +/* Define preprocessor symbols for MicroBlaze.
>> + Symbols which do not start with __ are deprecated. */
>
> If you really need the deprecated names, at least do not define them if
> flag_iso.
>
>> +#define TARGET_XLGP_OPT (target_flags & MASK_XLGPOPT)
>
> The option machinery automatically defines such macros. If you prefer the
> XLGP_OPT spelling, just change the .opt file to say Mask(XLGP_OPT), and
> you then get this macro automatically defined for you.
Made all these changes.
http://gcc.gnu.org/viewcvs?view=revision&revision=156908
or
svn diff svn://gcc.gnu.org/svn/gcc/branches/microblaze -r 156907:156908
See also change in config.gcc to build microblaze-c.o.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
More information about the Gcc-patches
mailing list