C++ PATCH for mangle11.C

Andrew Pinski pinskia@gmail.com
Tue Feb 16 21:03:00 GMT 2010


On Tue, Feb 16, 2010 at 1:01 PM, Mike Stump <mikestump@comcast.net> wrote:
>
>        * decl2.c (maybe_make_one_only): Be sure to always
>        call cxx_comdat_group, as it can produce abi warnings
>        for the symbol.
>
> Doing diffs in cp:
> --- cp/decl2.c.~1~      2010-02-15 17:16:36.000000000 -0800
> +++ cp/decl2.c  2010-02-16 12:33:33.000000000 -0800
> @@ -1622,6 +1622,10 @@ maybe_make_one_only (tree decl)
>   if (! flag_weak)
>     return;
>
> +  /* Do this first, as this can produce abi warnings, and we want to
> +     ensure the context of those warnings doesn't change.  */
> +  tree name = cxx_comdat_group (decl);

I think you want to move tree name definition before the checking of flag_weak.

Thanks,
Andrew Pinski



More information about the Gcc-patches mailing list