[PATCH] Fix --enable-checking=valgrind PCH failure

Jeff Law law@redhat.com
Thu Feb 11 20:10:00 GMT 2010


On 02/11/10 11:59, Jakub Jelinek wrote:
> Hi!
>
> The padding in v contains uninitialized garbage which we then write into
> the PCH file.  This isn't the only issue with --enable-checking=valgrind
> and PCH, the other issue is that PCH dumps the full size of allocated
> objects, even when they haven't been initialized at all (e.g. because token
> size is 0), which triggers errors with the valgrind markups.  Perhaps we'd
> need to temporarily make the unaccessible fields defined and reset it back
> or something similar.
>
> Anyway, this one is the easy part, bootstrapped/regtested on x86_64-linux
> and i686-linux, ok for trunk?
>
> 2010-02-11  Jakub Jelinek<jakub@redhat.com>
>
> 	* c-pch.c (pch_init): Clear v.
>    
OK
jeff



More information about the Gcc-patches mailing list