RFA: patch for PR42973

Vladimir Makarov vmakarov@redhat.com
Wed Feb 10 20:55:00 GMT 2010


Steven Bosscher wrote:
> On Wed, Feb 10, 2010 at 5:53 PM, Vladimir Makarov <vmakarov@redhat.com> wrote:
>   
>>
>> If there are no REG_DEAD notes, there is no sense to try copy generation.
>>  The code in the function after the mentioned code is expensive.  So major
>> purpose of the code fragment is to speed up constraint and shuffle copy
>> generation.
>>
>>     
>
> OK, perhaps it's just me, but I didn't understand that from the code.
> Could you add a comment there?
>
> Also, note you should do:
>
>   if (! find_reg_note (insn, REG_DEAD, NULL))
>     ...
>
> instead of the loop.
>   
Done.  Thanks for the proposal.

2010-02-10  Vladimir Makarov  <vmakarov@redhat.com>

    * ira-conflicts.c (add_insn_allocno_copies): Use find_reg_note
    instead of loop.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pr42973-change.patch
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20100210/db6bc512/attachment.ksh>


More information about the Gcc-patches mailing list