[patch] Fix PR42637

Sebastian Pop sebpop@gmail.com
Sun Feb 7 07:38:00 GMT 2010


Richard Guenther wrote:
> On Sat, Feb 6, 2010 at 6:04 PM, Sebastian Pop <sebpop@gmail.com> wrote:
> > Hi,
> >
> > The attached patches are fixing the PR42637, and add for all the loop
> > blocking and interchange tests in the Graphite C testsuite a runtime
> > check.  Patches have been bootstrapped and regtested on amd64-linux,
> > and also tested on the SPEC2006 benchmarks.  Committed to trunk.
> 
> 0007-Add-flag-to-dis-enable-cloog-optimization.patch is empty, so I suppose
> you didn't commit it (as it would need approval anyway)?
> 

I did not committed this part: I squashed this patch into the another
one before committing.

> Btw, the ChangeLog entries for the testsuite need [gcc/]testsuite/ stripped.
> 

Fixed in all the entries of the ChangeLog.graphite.

> Can you file a bug (if not existing) for the block testcases you xfail
> the runtime test?

All the block and interchange testcases for C contain a runtime test
that is enabled.  Some of the block testcases were miscompiled before
the fix for PR42637 and I disabled the runtime test only temporarily.

> (btw, a more portable runtime check is to add
>   if (...)
>     abort ();
>   return 0;
> instead of return res != ...;)
> 

Fixed.

I also have fixed the fails in the libgomp.graphite testsuite.  I will
commit this to the graphite branch for further test.  I will commit to
trunk once this passes the usual regstrap and SPEC 2006.

Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-format-in-ChangeLog.graphite.patch
Type: text/x-diff
Size: 57528 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20100207/24f3daf8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-PR42988-handle-unknown_dependence.patch
Type: text/x-diff
Size: 6300 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20100207/24f3daf8/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-new-testcases.patch
Type: text/x-diff
Size: 6324 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20100207/24f3daf8/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Call-abort-for-runtime-test-always-return-0-from-mai.patch
Type: text/x-diff
Size: 16492 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20100207/24f3daf8/attachment-0003.bin>


More information about the Gcc-patches mailing list