PATCH: Fix Solaris/SPARC bootstrap without gas

Eric Botcazou ebotcazou@adacore.com
Thu Feb 4 12:44:00 GMT 2010


> I really don't like this approach:
>
> * As far as I can see in config.gcc, there are no non-ELF SPARC targets
>   left, so no need for elf-gas.h.  Additionally, you are missing a
>   considerable set of other SPARC targets in your patch, which are most
>   likely equally affected.

Yes, sparc/gas.h is sufficient.  As for the other targets, they shouldn't be 
changed without testing and, in any cases, certainly not on the branches.

> * If we have to revisit this and do it properly, the right way to me
>   seems to simply check for the gas/as feature we need in configure.ac,
>   define an appropriate macro, and use that instead of statically
>   including some header.  It might even be that older versions of gas
>   don't support what we need (I have no idea, though), so the static
>   approach is highly problematic.

Maybe for 4.6, but we have to clean up the mess for 4.[345] so this approach 
is the best one for now.  As for older versions of gas, we could simplify 
revert all the changes on the 4.3 branch and consider 4.4+ only.

-- 
Eric Botcazou



More information about the Gcc-patches mailing list