Go testsuite patch committed: Avoid skipping tests inappropriately

Ian Lance Taylor iant@google.com
Tue Dec 21 22:57:00 GMT 2010


This patch to the Go testsuite driver go-test.exp avoids skipping some
tests inappropriately when invoking DejaGNU with go-test.exp=xxx.  The
problem is that go-test.exp calls runtest_file_p to see whether to run
the test.  If it should, then in a few cases it invokes go-dg-runtest to
do the testing, and that does another call to runtest_file_p.  However,
the second invocation will in some cases use a different name, because
some of the tests create a file and run tests on that.  This patch
temporarily clears the list of tests before calling go-dg-runtest, to
avoid inappropriately skipping the later test.  Bootstrapped and ran Go
testsuite on x86_64-unknown-linux-gnu.  Committed to mainline.

Ian


2010-12-21  Ian Lance Taylor  <iant@google.com>

	* go.test/go-test.exp: Clear runtests around invocation of
	go-dg-runtest from errchk and go-execute-xfail.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.patch
Type: text/x-diff
Size: 1317 bytes
Desc: testsuite
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20101221/9a907a60/attachment.bin>


More information about the Gcc-patches mailing list