[PATCH 3/6] Emit macro expansion related diagnostics

Dodji Seketeli dodji@redhat.com
Tue Dec 14 09:23:00 GMT 2010


Paolo Bonzini <bonzini@gnu.org> writes:

> On Tue, Dec 14, 2010 at 08:28, Gabriel Dos Reis
> <gdr@integrable-solutions.net> wrote:
>> Agreed.  But I also agree with Paolo's observation: the prefix "<locus>: note"
>> has to precede the diagnostic message.  I know there are other compilers
>> that do it differently, but GCC convention has been to precede diagnostics
>> with loci
>
> That was my main point, yes.  I'm not sure about the verboseness of
> having two lines per level of macro expansion, but I can live with
> that and it was secondary in my message.

OK, this is consistent with the discussion we've just had about re-using
functions like inform() in another sub-thread. I'll do that then.

Thanks.

-- 
	Dodji



More information about the Gcc-patches mailing list