PING^2: resubmitted IRA improvement patches

Richard Guenther richard.guenther@gmail.com
Fri Dec 10 16:58:00 GMT 2010


On Fri, Dec 10, 2010 at 5:23 PM, Vladimir Makarov <vmakarov@redhat.com> wrote:
> On 12/10/2010 11:08 AM, Jeff Law wrote:
>>
>> On 12/06/10 09:12, Kenneth Zadeck wrote:
>>>
>>> sorry, for taking so long.   i have been temporarily put on another
>>> project.
>>>
>>> i applied all of your patches to the trunk, and then reread all of the
>>> ira files looking for parts that i did not understand.    many of them
>>> relate to the patches at hand but some are things that should have been
>>> documented in earlier rounds that were just missed.  When these comments are
>>> properly addressed, you can check in your patches.
>>
>> I think in addition to addressing documentation issues you've raised, we
>> need to decide if we want this patch in GCC 4.6 or if it should be postponed
>> until GCC 4.7.
>>
>> The patch was clearly submitted early enough, but we're also further out
>> of stage1 than I'm comfortable just saying "go ahead and install".    My
>> temptation is still to get the patch in given its clear benefits, but I want
>> others to have a chance to chime in.
>
> I am pretty sure about the patch will not introduce new serious failures
> which can not be fixed quick.
>
> On the other hand, I'd expect some reports about performance or compilation
> problems for some targets (I checked only x86/x86-64, powerpc, and arm).
>  And that probably can not be fixed soon.
>
> It makes me think that submitting the patch at the beginning of stage #1 of
> gcc4.7 is probably a better idea.  In this case, I'll have plenty time to
> address these problems if we have them.

I agree, the patches do not look appropriate for this stage.

Thanks,
Richard.

>



More information about the Gcc-patches mailing list