PATCH: PR target/46770: Use .init_array/.fini_array sections

[Richard Guenther]

On Thu, Dec 9, 2010 at 7:44 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Dec 7, 2010 at 8:57 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Dec 7, 2010 at 8:31 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
>>> On Tue, 7 Dec 2010, H.J. Lu wrote:
>>>
>>>> @@ -2698,6 +2698,7 @@ esac
>>>>  case ${target} in
>>>>  i[34567]86-*-linux* | x86_64-*-linux*)
>>>>       tmake_file="${tmake_file} i386/t-pmm_malloc i386/t-i386"
>>>> +     use_initfini_array=yes
>>>
>>> Please update the comment at the top of config.gcc listing the variables
>>> it sets, and put a default (empty or "no") setting of this variable along
>>> with the other defaults as well.
>>
>> Done.
>>
>>>> +#include "tree.h"
>>>
>>> What is tree.h needed for here?
>>
>> DEFAULT_INIT_PRIORITY is defined in tree.h.
>>
>>>> +     $(TREE_H) $(GCC_H)
>>>
>>> I think you mean $(GGC_H) not $(GCC_H) (which is gcc.h, the header for the
>>> driver).
>>>
>>
>> Fixed.
>>
>>  Here is the updated patch. OK for trunk?
>>
>> Thanks.
>>
>> --
>> H.J.
>> ---
>> 2010-12-07  H.J. Lu  <hongjiu.lu@intel.com>
>>
>>        PR target/46770
>>        * config.gcc (use_initfini_array): New variable.
>>        Use initfini-array.o if supported.
>>
>>        * config/initfini-array.c: New.
>>        * config/initfini-array.h: Likewise.
>>        * config/t-initfini-array: Likewise.
>>
>
> This is a platform feature. I helped put this into gABI and implemented
> it in as/ld/glibc 10 years ago.  It is the time to enable it on Linux/x86 now.
> Any objections to check it in if there are no further comments in 48hours?

I don't see any approval.

Do you really think it is an appropriate change at this stage?

Thanks,
Richard.

> Thanks.
>
>
> --
> H.J.
>