[pph] Cleanup libcpp lookaside table.

Lawrence Crowl crowl@google.com
Thu Dec 9 23:04:00 GMT 2010


On 12/9/10, Diego Novillo <dnovillo@google.com> wrote:
> On 12/09/10 17:23, Lawrence Crowl wrote:
>> ! /* Call the GROK function for all the entries in the lookaside TABLE.
>> !    The cpp_lt_forall function passes PASSTHRU to each invocation of GROK,
>> !    in addition to the STR characters and their LEN
>> !    for each IDENT and MACRO value. */
>> ! /* FIXME: This code is presently unused, but may prove useful later.  */
>> ! #if 0
>
> Could you use 'FIXME pph' to make it easy to find all these when we
> merge back into trunk?

Done.

> I think I would just leave this code in, no #if 0.

The compiler complains about an unused function if there is no #if.
Another solution?

> Looks OK otherwise.

Committing...

> Tom, whenever you have some time, would you mind looking at all the
> stuff we've added to libcpp?  I suspect we probably need some more
> documentation.  I'm way overdue in creating a wiki for all this.  I'll
> try to get to it next week.

-- 
Lawrence Crowl



More information about the Gcc-patches mailing list