[PATCH,c++] fix PR 45330, suggest alternatives for failed name lookups

[Gabriel Dos Reis]

On Mon, Dec 6, 2010 at 1:05 PM, Jason Merrill <jason@redhat.com> wrote:
> On 12/06/2010 02:00 PM, Nathan Froyd wrote:
>>
>> Eh, so what's the desired way forward here?  AFAICS, the `+' modifier is
>> used only with `error' or `warning'.  But both of those functions use
>> input_location; if we want to get rid of input_location, it seems like
>> the easiest thing (along the way; surely this is not the only thing that
>> would be required) to do would be to excise `error' and `warning', use
>> their _at variants, remove the `+' modifiers from the diagnostic
>> strings, and use DECL_SOURCE_LOCATION or location_at or what have you at
>> the point of the call.
>
> Or you could just require that error/warning include a '+' modfier in the
> format string.  In any case, this sounds rather like the last change in the
> process of moving away from input_location, rather than the first.  :)

agreed.

-- Gaby