[PATCH] PR46667, fix section type conflicts

Ramana Radhakrishnan ramana.radhakrishnan@arm.com
Fri Dec 3 09:52:00 GMT 2010


On Thu, 2010-12-02 at 17:05 +0800, Chung-Lin Tang wrote:
> Hi,
> this patch tries to fix the section type conflicts seen on ARM-Linux 
> (which currently prevents libstdc++ from building on trunk) and the 
> reported x86-64 fails when -freorder-blocks-and-partition is involved.
> 
> The ARM fails seem to be due to DECL_ONE_ONLY symbols being treated as 
> added to the .text.unlikely section; I've added a call to 
> resolve_unique_section() to fill in the DECL_SECTION_NAME and 
> DECL_HAS_IMPLICIT_SECTION_NAME_P values as I see are needed.

I can't approve or reject your patch but ..

I don't see how that is wrong. Looking at a backtrace it does appear as
though a decl that needs a unique section gets a .text.unlikely. I've
tested your patch and it restores the testing to something sane.

Can someone approve this part of the patch to unbreak ARM builds of
libstdc++ ? 

Thanks,
Ramana





More information about the Gcc-patches mailing list