[vect] Ask for review and approving the patch about vect and loongson

[Mingjie Xing]

2010/8/24 Richard Sandiford <rdsandiford@googlemail.com>:
> Richard Guenther <richard.guenther@gmail.com> writes:
>> On Sat, Aug 21, 2010 at 10:29 AM, Richard Sandiford
>> <rdsandiford@googlemail.com> wrote:
>>> Uros Bizjak <ubizjak@gmail.com> writes:
>>>> On Tue, Aug 17, 2010 at 11:49 AM, Mingjie Xing <mingjie.xing@gmail.com> wrote:
>>>>> Updated. See the attachment.
>>>>
>>>> Perhaps we should extend the comment a bit:
>>>>
>>>> +# Check whether the vectorizer tests are supported by the target and append
>>>> +# additional target-dependent compile flags to DEFAULT_VECTFLAGS.  Also
>>>> +# set dg-do-what-default to either compile or run, depending on target
>>>> +# capabilities.  Return 1 if vectorizer tests are supported by
>>>> target, 0 otherwise.
>>>>
>>>>> Is it OK?
>>>>
>>>> Looks OK to me.  Richi, can you please formally approve the patch?
>>>
>>> Seems like this might have got stuck.  Mingjie's original patch is
>>> certainly a step forward in its own right, so Mingjie, please feel free
>>> to commit your original MIPS-specific gcc.dg/vect/vect.exp patch if you
>>> don't get an approval for this one in the next couple of days.  Please
>>> update the other two vect.exps in the same way, at the same time.
>>
>> As we do not have an (active) testsuite maintainer right now please treat
>> target specific changes as covered by your target maintainership.
>
> TBH, I'd been doing that even before Janis left. ;-)  And that's why
> I'd approved Mingjie's original patch when he posted it, before Uros
> pointed out that there were two other copies to update.
>
> I wasn't sure the patch to unify the three copies qualified as a
> MIPS-specific change though.  It changes the behaviour for ARM.
>
> Richard
>

Hi all, to make this easier, I now just modify the MIPS-specific
parts. The patch has been checked in. Thanks again.

Mingjie

2010-08-24  Mingjie Xing  <mingjie.xing@gmail.com>

        * gcc.dg/vect/vect.exp: Check loongson targets
        * g++.dg/vect/vect.exp: Likewise
        * gfortran.dg/vect/vect.exp: Likewise
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vect.patch
Type: text/x-diff
Size: 2367 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20100824/3d1249b9/attachment.bin>