PING: LTO: Add duplicates resolution to lto-plugin

[Diego Novillo]

On 10-08-05 03:55 , Andi Kleen wrote:
> Andi Kleen<andi@firstfloor.org>  writes:
>
>> PING for the lto-plugin patch at http://patchwork.ozlabs.org/patch/59133/
>
> PING^2: Can a LTO reviewer please review this patch?

Apologies for the delay.

> 2010-07-17  Andi Kleen  <ak@linux.intel.com>
>
> 	* lto-plugin.c: Include <hashtab.h>
> 	(sym_aux): Add next_conflict field to save conflict chains.
> 	(plugin_file_info): Add conflicts symtab.
> 	(parse_table_entry): Initialize aux->next_conflict.
> 	(dump_symtab): Add.
> 	(finish_conflict_resolution): Add.
> 	(free_symtab): Add.
> 	(write_resolution): Remove symbols loop and move into
> 	dump_symtab. Call dump_symtab for main symbol and conflicts table.
> 	Call free_symtab to free conflicts table.
> 	(SWAP): Add.
> 	(eq_sym): Add.
> 	(hash_sym): Add.
> 	(symbol_strength): Add.
> 	(resolve_conflicts): Add.
> 	(claim_file_handler): Add n variable. Check return value of
> 	process_symtab. Call resolve_conflicts.

Well, I'm not crazy about this.  Seems to me that this functionality 
could be in the linker proper, but since it's more specific to LTO, I 
guess it's better to have it in the plugin.

Please make sure that function arguments are referred to in capitals in 
comments and add spaces before '('s.  OK with those changes.


Diego.