Committed, MMIX: fix PR43889, missing earlyclobber exposed by r154688

Paolo Bonzini bonzini@gnu.org
Tue Apr 27 13:15:00 GMT 2010


>>>   (define_insn "*divdi3_nonknuth"
>>> -  [(set (match_operand:DI 0 "register_operand" "=&r,r")
>>> +  [(set (match_operand:DI 0 "register_operand" "=&r,&r")
>>>   	(div:DI (match_operand:DI 1 "register_operand" "r,r")
>>>   		(match_operand:DI 2 "register_operand" "1,r")))
>>>      (clobber (match_scratch:DI 3 "=1,1"))
>>
>> Even after your patch, I'm not at all convinced these are valid
>> patterns, what with the "=1" matching constraint on a clobber.
>
> How is that?  I don't see how I need an earlyclobber there too.

The earlyclobber would be surely wrong, since then you couldn't access 
the input operand.  I think the clobber is fine though.

Paolo



More information about the Gcc-patches mailing list