enable fdiagnostics-show-option by default

[Gabriel Dos Reis]

On Thu, Apr 15, 2010 at 12:49 PM, Manuel López-Ibáñez
<lopezibanez@gmail.com> wrote:
> This patch enables the option -fdiagnostics-show-option by default:
>
> This changes the output from this:
>
> Wconversion-integer.c:52:3: warning: negative integer implicitly
> converted to unsigned type
>
> to this:
>
> Wconversion-integer.c:52:3: warning: negative integer implicitly
> converted to unsigned type [-Wsign-conversion]
>
> which is much nicer and helpful!
>
> Of course, -fno-diagnostics-show-option disables this.
>
> Since any current parsers of gcc output have to expect anything after
> the warning/error marker, then this is quite safe. In fact, only one
> testcase needed to be modified.
>
> BTW, when testing a warning, if you are not interested in the text,
> you can just match the Woption in the message.
>
> Bootstrapped and regression tested.
>
> OK for trunk?

This would add to the substantial amount of output, especially if the
warnings are repeated.

I would prefer this behaviour to be configurable at configure-time, so that
users or packagers can decide which behaviour is

-- Gaby